Sum of Absolute Differences Benchmark #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Cleaned up the host code from having multiple matrix dimensions 3. Added README
2. Added safeguard against result dimensions not being a multiplicant of tile group dimensions
drichmond
reviewed
Mar 16, 2020
Comment on lines
+36
to
+56
| int __attribute__ ((noinline)) sum_abs_diff_single_work_per_tile (int *REF, int *FRAME, int *RES, | ||
| uint32_t ref_height, uint32_t ref_width, | ||
| uint32_t frame_height, uint32_t frame_width, | ||
| uint32_t res_height, uint32_t res_width) { | ||
|
|
||
| int start_y = __bsg_tile_group_id_y * bsg_tiles_Y + bsg_y; | ||
| int end_y = MIN (start_y + frame_height, res_height); | ||
| int start_x = __bsg_tile_group_id_x * bsg_tiles_X + bsg_x; | ||
| int end_x = MIN (start_x + frame_width, res_width); | ||
|
|
||
|
|
||
| int sad = 0; | ||
| for (int y = start_y; y < end_y; y ++) { | ||
| for (int x = start_x; x < end_x; x ++) { | ||
| sad += ABS ( (REF[y * ref_width + x] - FRAME[(y - start_y) * frame_width + (x - start_x)]) ); | ||
| } | ||
| } | ||
|
|
||
| RES[start_y * res_width + start_x] = sad; | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
As I said in the meeting - if you use templates for the input datatype you won't have binary bloat. I think it's worth your time to do this.
There was a problem hiding this comment.
If you're worried about namespace collision you can do:
namespace v0{
// Kernel source
}
And then in the kernel.cpp file:
using namespace v0;
drichmond
reviewed
Mar 16, 2020
Comment on lines
+31
to
+34
| /******************************************************************************/ | ||
| /* Runs the sum ob absolute differences kernel between a reference and a */ | ||
| /* frame image (represented by 3D RGB pixel matrixes) */ | ||
| /******************************************************************************/ |
There was a problem hiding this comment.
Two comments:
- ob -> of
- The comment boxes are hard to maintain and add a lot of whitespace. Can you make them a single comment (i.e.
/******************************************************************************
* Runs the sum ob absolute differences kernel between a reference and a
* frame image (represented by 3D RGB pixel matrixes)
******************************************************************************/
or
// *****************************************************************************
// Runs the sum ob absolute differences kernel between a reference and a
// frame image (represented by 3D RGB pixel matrixes)
// *****************************************************************************
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To compare against the "SAD" testbench in the IMPACT Parboil benchmark.